Skip to content

Fix: Auth method for checkout page api requests to ub service #6996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

Fix: Auth method for checkout page api requests to ub service #6996

merged 1 commit into from
May 10, 2025

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented May 9, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on refactoring the code to remove unnecessary parameters, improve naming consistency, and enhance functionality in several components related to token management and checkout processes.

Detailed summary

  • Removed clientId from useTokensData and getWebhooks.
  • Changed CardTitle text from "Create a Checkout Link" to "Create a Payment Link".
  • Added authToken check in RoutesPage for redirecting to login.
  • Updated headers in API calls to use DASHBOARD_THIRDWEB_SECRET_KEY.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl requested review from a team as code owners May 9, 2025 23:55
@changeset-bot
Copy link

changeset-bot bot commented May 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4c7d775

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2025 0:25am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) May 10, 2025 0:25am
login ⬜️ Skipped (Inspect) May 10, 2025 0:25am
thirdweb_playground ⬜️ Skipped (Inspect) May 10, 2025 0:25am
wallet-ui ⬜️ Skipped (Inspect) May 10, 2025 0:25am

@graphite-app
Copy link
Contributor

graphite-app bot commented May 9, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label May 9, 2025
graphite-app[bot]
graphite-app bot reviewed May 9, 2025
View reviewed changes
@gregfromstl gregfromstl force-pushed the greg/checkout-api-auth branch from 266acd2 to 3c3d520 Compare May 9, 2025 23:56
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 23:56 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 23:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 23:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 23:56 Inactive
@codecov
Copy link

codecov bot commented May 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (2297915) to head (4c7d775).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6996   +/-   ##
=======================================
  Coverage   54.60%   54.60%           
=======================================
  Files         903      903           
  Lines       57934    57934           
  Branches     3970     3970           
=======================================
  Hits        31632    31632           
  Misses      26202    26202           
  Partials      100      100
Flag Coverage Δ
packages 54.60% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gregfromstl gregfromstl force-pushed the greg/checkout-api-auth branch from 3c3d520 to dea673a Compare May 9, 2025 23:58
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 9, 2025 23:58 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 9, 2025 23:58 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 9, 2025 23:58 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 9, 2025 23:58 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2025 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 54.16 KB (-0.03% 🔽) 1.1 s (-0.03% 🔽) 326 ms (+97.21% 🔺) 1.5 s
thirdweb (cjs) 193.88 KB (0%) 3.9 s (0%) 782 ms (+18.68% 🔺) 4.7 s
thirdweb (minimal + tree-shaking) 5.69 KB (0%) 114 ms (0%) 80 ms (+467.63% 🔺) 193 ms
thirdweb/chains (tree-shaking) 524 B (0%) 11 ms (0%) 35 ms (+813.98% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 19.51 KB (0%) 391 ms (0%) 109 ms (+243.27% 🔺) 499 ms

@gregfromstl gregfromstl force-pushed the greg/checkout-api-auth branch from dea673a to 9131e97 Compare May 10, 2025 00:12
@vercel vercel bot temporarily deployed to Preview – login May 10, 2025 00:12 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 10, 2025 00:12 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 10, 2025 00:12 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 10, 2025 00:12 Inactive
@gregfromstl gregfromstl force-pushed the greg/checkout-api-auth branch from 9131e97 to 4c7d775 Compare May 10, 2025 00:13
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground May 10, 2025 00:13 Inactive
@vercel vercel bot temporarily deployed to Preview – login May 10, 2025 00:13 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui May 10, 2025 00:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 May 10, 2025 00:13 Inactive
@gregfromstl gregfromstl merged commit a4e12c5 into main May 10, 2025
23 checks passed
@gregfromstl gregfromstl deleted the greg/checkout-api-auth branch May 10, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

Assignees

@gregfromstl gregfromstl

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gregfromstl